-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Move more sections under hardware integration #2704
docs: Move more sections under hardware integration #2704
Conversation
63d2671
to
b8f67d2
Compare
I agree that the additional refactoring could be done in a future PR. I think that the config and feature pages ought to also be combined into one. Battery bit LGTM. |
How do you envision this? I thought it's nice to have all the features' config as reference under configuration. If we move them to e.g. the feature page then the config reference section will be incomplete. |
I was unclear I think: feature pages combined into one and config pages combined into one, making two from four. |
Got it, yeah that makes sense. Will break quite a few links, and I should remember to add redirects. |
b8f67d2
to
49062b9
Compare
49062b9
to
e21ab9d
Compare
I (finally) consolidated the underglow+backlight feature and config pages as well. I added redirects for the old pages, though I don't think they work on local builds or in deploy previews. While debugging any missing links, I also noticed the missing anchors on the dongle page, opened #2764. Another extra is I removed an incorrect redirect from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just one little note.
e21ab9d
to
f36707a
Compare
Move portions of pages that describe hardware integration parts from feature pages into dedicated pages under Hardware Integration section.
PR check-list